Handle footnote names that have been parsed into multiple nodes #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalmoksha
force-pushed
the
bw-fix-footnote-special-chars
branch
from
05a4943
to
174ef95
Compare
digitalmoksha
force-pushed
the
bw-fix-footnote-special-chars
branch
from
174ef95
to
56aa94c
Compare
|
@kivikakk I think this one is ready for review. I think this PR also addresses #271, so added a test for that. You mentioned in #308 (comment) about using an enum for casing - the second commit is my attempt at that. Feel free to tweak as you desire. EDIT:
I didn't adjust the lexer at all, it mostly seems to be happening naturally. 🤷 |
kivikakk
approved these changes
Jun 5, 2023
src/strings.rs
Outdated
Comment on lines
262
to
265
| if Case::Preserve == casing { | ||
| v.push(c); | ||
| } else { | ||
| v.push_str(&c.to_lowercase().to_string()); |
There was a problem hiding this comment.
You could also consider something like this in future, I think it's probably considered more "idiomatic Rust":
Suggested change
| if Case::Preserve == casing { | |
| v.push(c); | |
| } else { | |
| v.push_str(&c.to_lowercase().to_string()); | |
| match casing { | |
| Case::Preserve => v.push(c), | |
| Case::DontPreserve => v.push_str(&c.to_lowercase().to_string()), |
There was a problem hiding this comment.
Ah thanks. I went ahead and applied this to the original commit and force pushed.
|
This ran into an issue with fuzzing almost immediately: I've pushed a commit that includes the fuzzer for you to run, too. In this case, it looks like we presume the presence of a text node also implies it's non-empty, but isn't always. I've made the fix for this and hit another one: This is getting thorny quickly, so I'll leave more to you. The repro case is as follows: You can pipe this text into To run the fuzzer yourself, the following command runs it (on six cores): You'll need to install a nightly Rust toolchain and |
digitalmoksha
force-pushed
the
bw-fix-footnote-special-chars
branch
from
0d6a5c9
to
014d341
Compare
into multiple nodes. For example `[^_foo]` gives `^`, `_`, and `foo`.
digitalmoksha
force-pushed
the
bw-fix-footnote-special-chars
branch
from
014d341
to
e80ed0e
Compare
|
So the |
|
Thanks so much, this looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example
[^_foo]gives^,_, andfoo.Related
cmark-gfmPR: github/cmark-gfm#229Related issue: #306